Add control_keys protocol (simplified) #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use control keys in circuit construction to block controlled gates "earliest" append method from falling back to before the measurement.
|
@95-martin-orion This is the most time-sensitive of my open PRs right now. None of the others are blocking progress on classical control. |
95-martin-orion
approved these changes
Nov 4, 2021
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Use control keys in circuit construction to block controlled gates "earliest" append method from falling back to before the measurement. Parts 5&7 of https://tinyurl.com/cirq-feedforward. (I grouped them together in a single PR so that circuit.append could be a POC that control_keys protocol design works as intended). Replaces/simplifies quantumlib#4490 since we will handle "extern" control keys in subcircuits as a separate PR.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Use control keys in circuit construction to block controlled gates "earliest" append method from falling back to before the measurement. Parts 5&7 of https://tinyurl.com/cirq-feedforward. (I grouped them together in a single PR so that circuit.append could be a POC that control_keys protocol design works as intended). Replaces/simplifies quantumlib#4490 since we will handle "extern" control keys in subcircuits as a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use control keys in circuit construction to block controlled gates "earliest" append method from falling back to before the measurement.
Parts 5&7 of https://tinyurl.com/cirq-feedforward. (I grouped them together in a single PR so that circuit.append could be a POC that control_keys protocol design works as intended).
Replaces/simplifies #4490 since we will handle "extern" control keys in subcircuits as a separate PR.