Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix measurement keys in subcircuits with parent_path #4616

Merged
merged 7 commits into from
Nov 10, 2021
Merged

Fix measurement keys in subcircuits with parent_path #4616

merged 7 commits into from
Nov 10, 2021

Conversation

daxfohl
Copy link
Contributor

@daxfohl daxfohl commented Nov 2, 2021 •
edited
Loading

Applies any parent path in subcircuit to measurement key before returning.

Fixes #4620

@daxfohl daxfohl requested review from cduck, vtomole and a team as code owners November 2, 2021 02:54
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Nov 2, 2021
@daxfohl daxfohl requested a review from viathor November 2, 2021 02:54
@CirqBot CirqBot added the size: S 10< lines changed <50 label Nov 2, 2021
This was referenced Nov 2, 2021
Closed
Closed
@95-martin-orion
Copy link
Collaborator

Thsi seems fine to me, though it might be worthwhile to wait for #4619 to merge and use with_key_path_prefix instead.

@daxfohl
Copy link
Contributor Author

daxfohl commented Nov 10, 2021

@95-martin-orion done

95-martin-orion
95-martin-orion approved these changes Nov 10, 2021
View reviewed changes
Copy link
Collaborator

@95-martin-orion 95-martin-orion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending test renaming to fix checks.

@daxfohl
Copy link
Contributor Author

daxfohl commented Nov 10, 2021

@95-martin-orion fixed

@95-martin-orion 95-martin-orion added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 10, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 10, 2021
@CirqBot CirqBot merged commit 13e0225 into quantumlib:master Nov 10, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Nov 10, 2021
@daxfohl daxfohl deleted the fix_subcircuit_key branch November 10, 2021 21:16
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@daxfohl @rht
Fix measurement keys in subcircuits with parent_path (quantumlib#4616)
b05d28a 
Applies any parent path in subcircuit to measurement key before returning.

Fixes quantumlib#4620
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@daxfohl
Fix measurement keys in subcircuits with parent_path (quantumlib#4616)
9bf176c 
Applies any parent path in subcircuit to measurement key before returning.

Fixes quantumlib#4620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@95-martin-orion 95-martin-orion 95-martin-orion approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@viathor viathor Awaiting requested review from viathor viathor was automatically assigned from quantumlib/cirq-maintainers

Assignees

@95-martin-orion 95-martin-orion

Labels
cla: yes Makes googlebot stop complaining. size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

subciruit._measurement_keys_() does not include parent path
3 participants
@daxfohl @95-martin-orion @CirqBot