Add LazyLoader for delayed imports of slow modules #4653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabacon
requested review from
cduck,
mrwojtek,
vtomole and
a team
as code owners
95-martin-orion
approved these changes
Nov 10, 2021
I think so yes, I think I can probably craft a regex to look for those. |
Open
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
This allows for delayed import for modules, which is useful when the modules load time is slow and we don't want these imports on a global level.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
This allows for delayed import for modules, which is useful when the modules load time is slow and we don't want these imports on a global level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A solution for #4648
This creates a class
LazyLoaderthat can be used in place of an import and delays importing the module.For classes that take up extra initialization time this speeds the overall first import of cirq with the potential downside of slowing doing the first uses where it is used.
This PR applies this to previous cases of delayed imports in scipy.