Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter resolution and other utility methods to _InverseCompositeGate #4656

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Add parameter resolution and other utility methods to _InverseCompositeGate #4656

merged 3 commits into from
Nov 10, 2021

Conversation

tanujkhattar
Copy link
Collaborator

Fixes #4655

This PR adds functionality to _InverseCompositeGate to forward requests like resolve_parameters, is_parameterized and parameter_names to the underlying original_gate.

@tanujkhattar tanujkhattar requested review from cduck, vtomole and a team as code owners November 10, 2021 21:20
@tanujkhattar tanujkhattar requested a review from viathor November 10, 2021 21:20
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Nov 10, 2021
@CirqBot CirqBot added the size: S 10< lines changed <50 label Nov 10, 2021
dabacon
dabacon previously approved these changes Nov 10, 2021
View reviewed changes
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dabacon
Copy link
Collaborator

dabacon commented Nov 10, 2021

Doesn't look like I can approve yet @MichaelBroughton

@MichaelBroughton
Copy link
Collaborator

How about now ?

viathor
viathor previously approved these changes Nov 10, 2021
View reviewed changes
@viathor
Copy link
Collaborator

viathor commented Nov 10, 2021

Oops

@MichaelBroughton MichaelBroughton dismissed stale reviews from viathor and dabacon November 10, 2021 22:41

Testing Dave can approve

dabacon
dabacon approved these changes Nov 10, 2021
View reviewed changes
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM part 2

@dabacon dabacon merged commit 5fdf764 into quantumlib:master Nov 10, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tanujkhattar @rht
Add parameter resolution and other utility methods to _InverseComposi…
d11a8e8 
…teGate (quantumlib#4656)
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@tanujkhattar
Add parameter resolution and other utility methods to _InverseComposi…
331fc0f 
…teGate (quantumlib#4656)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabacon dabacon dabacon approved these changes

@viathor viathor viathor left review comments

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

Assignees

@dabacon dabacon

Labels
cla: yes Makes googlebot stop complaining. size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cirq.Simulator doesn't support inverse gates that use sympy arguments for gates that don't define __pow__
5 participants
@tanujkhattar @dabacon @MichaelBroughton @viathor @CirqBot