Add docker and docker compose to dev install #4661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBroughton
approved these changes
Nov 11, 2021
| @@ -1,2 +1,4 @@ | |||
| virtualenvwrapper | |||
| pandoc | |||
| docker-ce | |||
There was a problem hiding this comment.
Nit: leave a comment here indicating these are currently Rigetti only dependencies.
There was a problem hiding this comment.
If I add a comment here it will be necessary to strip these out when doing the apt-get xargs command that is described in development.md
I'll add a comment in development.md
dabacon
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
We have docker tests and rigetti requires docker. This adds these to the dev apt-get list and explains that you need to install docker.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Missed comment in quantumlib#4661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have docker tests and rigetti requires docker. This adds these to the dev apt-get list and explains that you need to install docker.