Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing documentation lint errors even further #4687

Merged
merged 4 commits into from
Nov 15, 2021

Conversation

dabacon
Copy link
Collaborator

@dabacon dabacon commented Nov 15, 2021

No description provided.

@dabacon dabacon requested a review from viathor November 15, 2021 17:34
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Nov 15, 2021
@CirqBot CirqBot added the size: M 50< lines changed <250 label Nov 15, 2021
Copy link
Collaborator

@viathor viathor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Thanks!

@@ -160,8 +160,7 @@ class name via a dot (.)


# Copying the Python API, whose usage of `repr` annoys pylint.
# TODO(#3388) Add documentation for Args.
# pylint: disable=redefined-builtin, missing-param-doc
# pylint: disable=redefine-builtin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be: redefined-builtin

(Applies on l.222 below, too.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@dabacon dabacon added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 15, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 15, 2021
@dabacon dabacon merged commit 1360fb6 into quantumlib:master Nov 15, 2021
@dabacon dabacon deleted the finalcountdown branch April 16, 2022 15:42
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Tells CirqBot to sync and merge this PR. (If it's running.) cla: yes Makes googlebot stop complaining. front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants