[cirqflow] Convenience method for loading results #4720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cg.ExecutableGroupResultFilesystemRecord.from_json(run_id)
|
@tanujkhattar do you have any comments on this before I flesh it out. Fixes #4732 |
Comment on lines
+51
to
+52
| fn = f'{base_data_dir}/{run_id}/ExecutableGroupResultFilesystemRecord.json.gz' | ||
| egr_record = cirq.read_json_gzip(fn) |
There was a problem hiding this comment.
Nice, I didn't realize we were also storing ExecutableGroupResultFilesystemRecord and therefore we can fetch the runtime_configuration_path, shared_runtime_info_path etc. by directly reading this json instead of hardcoding any paths here.
mpharrigan
requested review from
cduck,
vtomole,
wcourtney and
a team
as code owners
tanujkhattar
approved these changes
Dec 22, 2021
tanujkhattar
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
MichaelBroughton
pushed a commit
to MichaelBroughton/Cirq
that referenced
this pull request
Jan 22, 2022
Add cg.ExecutableGroupResultFilesystemRecord.from_json(run_id)
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Add cg.ExecutableGroupResultFilesystemRecord.from_json(run_id)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cg.ExecutableGroupResultFilesystemRecord.from_json(run_id)