Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QASM parsing for classical controls #4738

Merged
merged 2 commits into from
Dec 13, 2021
Merged

QASM parsing for classical controls #4738

merged 2 commits into from
Dec 13, 2021

Conversation

daxfohl
Copy link
Contributor

@daxfohl daxfohl commented Dec 8, 2021

Part 11 of https://tinyurl.com/cirq-feedforward. This is self-contained in the QASM lexer and parser classes.

@daxfohl daxfohl requested review from cduck, vtomole and a team as code owners December 8, 2021 23:43
@daxfohl daxfohl requested a review from viathor December 8, 2021 23:43
@CirqBot CirqBot added the size: S 10< lines changed <50 label Dec 8, 2021
MichaelBroughton
MichaelBroughton approved these changes Dec 13, 2021
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton self-assigned this Dec 13, 2021
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Dec 13, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Dec 13, 2021
@CirqBot CirqBot merged commit b7bfb10 into quantumlib:master Dec 13, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Dec 13, 2021
@daxfohl daxfohl deleted the qasm branch December 13, 2021 20:49
MichaelBroughton pushed a commit to MichaelBroughton/Cirq that referenced this pull request Jan 22, 2022
@daxfohl @MichaelBroughton
QASM parsing for classical controls (quantumlib#4738)
0a986bf 
Part 11 of https://tinyurl.com/cirq-feedforward. This is self-contained in the QASM lexer and parser classes.
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@daxfohl @rht
QASM parsing for classical controls (quantumlib#4738)
b49d759 
Part 11 of https://tinyurl.com/cirq-feedforward. This is self-contained in the QASM lexer and parser classes.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@daxfohl
QASM parsing for classical controls (quantumlib#4738)
01469ab 
Part 11 of https://tinyurl.com/cirq-feedforward. This is self-contained in the QASM lexer and parser classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@viathor viathor Awaiting requested review from viathor viathor was automatically assigned from quantumlib/cirq-maintainers

Assignees

@MichaelBroughton MichaelBroughton

Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daxfohl @MichaelBroughton @CirqBot