-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore deprecation warnings from protobufs #4751
Ignore deprecation warnings from protobufs #4751
Conversation
conftest.py
Outdated
# Eventually, the warnings will be removed by upgrading protoc compiler. However, at | ||
# the moment upgrading breaks TensorFlow Quantum and therefore is deferred. See issues | ||
# #4161 and #4737. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TensorFlow Quantum is no longer blocking here. It is the fact that nobody has bothered to do a GAPIC rebuild of the v1alpha1 protos.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated comment. PTAL
Is there anything I need to do to get this to apply? I'm running |
@mpharrigan Could you double check whether the warnings you're seeing are the protobuf deprecation warnings shown in #4737 or other types of warnings? The fix in this PR worked for me in the sense that I saw only other types of warnings (and was a little dismayed that those creeped in during the time everybody was ignoring warnings due to the flood brought about by protobuf). |
I think so? see below for running
|
Fixes #4737 temporarily.