Make PauliMeasurementGate respect sign of the pauli observable.
#4836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanujkhattar
added
the
BREAKING CHANGE
MichaelBroughton
approved these changes
Jan 14, 2022
| coefficient = ( | ||
| observable.coefficient if isinstance(observable, dps.BaseDensePauliString) else 1 | ||
| ) | ||
| if coefficient not in [+1, -1]: |
There was a problem hiding this comment.
Nit: can just do [1, -1]
tanujkhattar
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
MichaelBroughton
pushed a commit
to MichaelBroughton/Cirq
that referenced
this pull request
Jan 22, 2022
…antumlib#4836) Fixes quantumlib#4814 Note that this is a breaking change because: - Serialization of the `PauliMeasurementGate` is now different -- the serialized observable is `DensePauliString` instead of a tuple of Pauli's. - A DensePauliString with coefficient != +1/-1 will now raise a `ValueError` whereas earlier the coefficient was simply ignored.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…antumlib#4836) Fixes quantumlib#4814 Note that this is a breaking change because: - Serialization of the `PauliMeasurementGate` is now different -- the serialized observable is `DensePauliString` instead of a tuple of Pauli's. - A DensePauliString with coefficient != +1/-1 will now raise a `ValueError` whereas earlier the coefficient was simply ignored.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…antumlib#4836) Fixes quantumlib#4814 Note that this is a breaking change because: - Serialization of the `PauliMeasurementGate` is now different -- the serialized observable is `DensePauliString` instead of a tuple of Pauli's. - A DensePauliString with coefficient != +1/-1 will now raise a `ValueError` whereas earlier the coefficient was simply ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4814
Note that this is a breaking change because:
PauliMeasurementGateis now different -- the serialized observable isDensePauliStringinstead of a tuple of Pauli's.ValueErrorwhereas earlier the coefficient was simply ignored.