-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow clifford simulator to run as product state #4844
Merged
Merged
+91
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxfohl
commented
Jan 15, 2022
MichaelBroughton
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after small nit.
@MichaelBroughton I fixed the nit, this should be good to go. |
@MichaelBroughton did this fall off your radar? |
Oops, yes. Sorry. |
MichaelBroughton
added
the
automerge
Tells CirqBot to sync and merge this PR. (If it's running.)
label
Jan 26, 2022
CirqBot
added
the
front_of_queue_automerge
CirqBot uses this label to indicate (and remember) what's being merged next.
label
Jan 26, 2022
CirqBot
removed
automerge
Tells CirqBot to sync and merge this PR. (If it's running.)
front_of_queue_automerge
CirqBot uses this label to indicate (and remember) what's being merged next.
labels
Jan 26, 2022
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Closes quantumlib#4828 I did verify that it is consistent across a large set of random circuits. There does seem to be some overhead, ~10%, in non-separable states so I left the default behavior as not to separate states. However I also verified there's a roughly linear speedup when the states are separable.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Closes quantumlib#4828 I did verify that it is consistent across a large set of random circuits. There does seem to be some overhead, ~10%, in non-separable states so I left the default behavior as not to separate states. However I also verified there's a roughly linear speedup when the states are separable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4828
I did verify that it is consistent across a large set of random circuits. There does seem to be some overhead, ~10%, in non-separable states so I left the default behavior as not to separate states. However I also verified there's a roughly linear speedup when the states are separable.