Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clifford simulator to run as product state #4844

Merged
merged 7 commits into from
Jan 26, 2022
Merged

Conversation

daxfohl
Copy link
Collaborator

@daxfohl daxfohl commented Jan 15, 2022

Closes #4828

I did verify that it is consistent across a large set of random circuits. There does seem to be some overhead, ~10%, in non-separable states so I left the default behavior as not to separate states. However I also verified there's a roughly linear speedup when the states are separable.

@daxfohl daxfohl requested review from cduck, vtomole and a team as code owners January 15, 2022 07:31
@daxfohl daxfohl requested a review from tanujkhattar January 15, 2022 07:31
@CirqBot CirqBot added the size: M 50< lines changed <250 label Jan 15, 2022
@MichaelBroughton MichaelBroughton self-assigned this Jan 19, 2022
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after small nit.

cirq-core/cirq/sim/clifford/stabilizer_state_ch_form.py Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@daxfohl
Copy link
Collaborator Author

daxfohl commented Jan 21, 2022

@MichaelBroughton I fixed the nit, this should be good to go.

@daxfohl
Copy link
Collaborator Author

daxfohl commented Jan 26, 2022

@MichaelBroughton did this fall off your radar?

@MichaelBroughton
Copy link
Collaborator

Oops, yes. Sorry.

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jan 26, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jan 26, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@CirqBot CirqBot merged commit 497cd3d into quantumlib:master Jan 26, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jan 26, 2022
@daxfohl daxfohl deleted the ch branch January 29, 2022 22:32
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023

Verified

This commit was signed with the committer’s verified signature.
Closes quantumlib#4828

I did verify that it is consistent across a large set of random circuits. There does seem to be some overhead, ~10%, in non-separable states so I left the default behavior as not to separate states. However I also verified there's a roughly linear speedup when the states are separable.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Closes quantumlib#4828

I did verify that it is consistent across a large set of random circuits. There does seem to be some overhead, ~10%, in non-separable states so I left the default behavior as not to separate states. However I also verified there's a roughly linear speedup when the states are separable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separable CH-form
3 participants