Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backwards incompatible pandas usage. #4873

Merged
merged 2 commits into from
Jan 23, 2022
Merged

Fix backwards incompatible pandas usage. #4873

merged 2 commits into from
Jan 23, 2022

Conversation

MichaelBroughton
Copy link
Collaborator

Experiment with latest CI break.

@MichaelBroughton MichaelBroughton requested review from cduck, vtomole and a team as code owners January 22, 2022 19:58
@CirqBot CirqBot added the Size: XS <10 lines changed label Jan 22, 2022
@MichaelBroughton MichaelBroughton changed the title Updated numpy 1.16 -> 1.19. Fix backwards incompatible pandas usage. Jan 22, 2022
@vtomole
Copy link
Collaborator

vtomole commented Jan 23, 2022

We have a pandas break on this run: https://github.com/quantumlib/Cirq/runs/4914290551?check_suite_focus=true

@vtomole
Copy link
Collaborator

vtomole commented Jan 23, 2022

https://github.com/quantumlib/Cirq/runs/4914785919?check_suite_focus=true as well:

pandas.errors.InvalidIndexError: (slice(None, None, None), None)

@MichaelBroughton
Copy link
Collaborator Author

This PR will fix those.

vtomole
vtomole approved these changes Jan 23, 2022
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jan 23, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jan 23, 2022
@CirqBot CirqBot merged commit 90679d2 into quantumlib:master Jan 23, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jan 23, 2022
@MichaelBroughton MichaelBroughton deleted the bump_numpy branch January 23, 2022 21:20
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@MichaelBroughton @rht
Fix backwards incompatible pandas usage. (quantumlib#4873)
a41481c 
Experiment with latest CI break.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@MichaelBroughton
Fix backwards incompatible pandas usage. (quantumlib#4873)
5b499fe 
Experiment with latest CI break.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole approved these changes

@cduck cduck Awaiting requested review from cduck

@mpharrigan mpharrigan Awaiting requested review from mpharrigan mpharrigan was automatically assigned from quantumlib/cirq-maintainers

@mrwojtek mrwojtek Awaiting requested review from mrwojtek

Assignees
No one assigned
Labels
Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelBroughton @vtomole @CirqBot