Allow repeated measurement keys #4899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxfohl
commented
Feb 14, 2022
|
Update: #4555 has been merged. |
|
@95-martin-orion integrated. Should be gtg |
Comment on lines
+828
to
+829
| _allow_repeated: If True, adds extra dimension to the result, | ||
| corresponding to the number of times a key is repeated. |
There was a problem hiding this comment.
IIUC, this is required for backwards-compatibility, since SimulatorBase._run expects a 3D array to feed into the result records. Is that correct? Is there anything else motivating this addition?
Asking because it feels unwieldy, and I'd like to avoid it if it's not too complicated to do so.
There was a problem hiding this comment.
Right, so this is StepResult.sample_meaurement_ops. Since it is public, I didn't want to change the return type or behavior. It's called from SimulatorBase._run. Options I considered were:
- Create a separate method for 3D arrays that allows duplicates
- Skipping this option in
SimulatorBase._runand having everything go through the full-simulation path (would be much slower this way I believe) - Just inlining the logic here into
SimulatorBase._run
This seemed like the most reasonable solution, but either of the others would work too. It would be nice to eventually (or immediately) make the breaking change such that everything returns a 3D array instead of 2D. If we want to continue to offer both 2D and 3D support indefinitely then maybe they should be separate functions instead of parameter-dependent. I'm also fully open to making the parameter non-private.
95-martin-orion
approved these changes
Feb 15, 2022
Comment on lines
+828
to
+829
| _allow_repeated: If True, adds extra dimension to the result, | ||
| corresponding to the number of times a key is repeated. |
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
|
This may be causing issues in external simulators: #5000 |
95-martin-orion
pushed a commit
to 95-martin-orion/Cirq
that referenced
this pull request
Mar 2, 2022
Allow repeated measurement keys. Implements steps 1, 2, 3, and 4 from quantumlib#4274 (comment): 1. Expand ClassicalDataStore with the extra dimension 2. Remove the exception if a measurement is repeated and just toss it into the extra dimension. 3. Ensure the generated `log_of_measurement_results` grabs the most recent index. (This step "just worked" by virtue of having a default index=-1). 4. Add an optional `index` property to `KeyCondition` to specify which index to use in classical controls (default `-1`). Step 5 will be a surprisingly straightforward follow-up to this one daxfohl/Cirq@repeated...daxfohl:repeated2 (still needs fleshed out for serializing the new field etc.). Step 6 is being done in parallel in quantumlib#4949 and subsequent PRs.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Allow repeated measurement keys. Implements steps 1, 2, 3, and 4 from quantumlib#4274 (comment): 1. Expand ClassicalDataStore with the extra dimension 2. Remove the exception if a measurement is repeated and just toss it into the extra dimension. 3. Ensure the generated `log_of_measurement_results` grabs the most recent index. (This step "just worked" by virtue of having a default index=-1). 4. Add an optional `index` property to `KeyCondition` to specify which index to use in classical controls (default `-1`). Step 5 will be a surprisingly straightforward follow-up to this one daxfohl/Cirq@repeated...daxfohl:repeated2 (still needs fleshed out for serializing the new field etc.). Step 6 is being done in parallel in quantumlib#4949 and subsequent PRs.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Allow repeated measurement keys. Implements steps 1, 2, 3, and 4 from quantumlib#4274 (comment): 1. Expand ClassicalDataStore with the extra dimension 2. Remove the exception if a measurement is repeated and just toss it into the extra dimension. 3. Ensure the generated `log_of_measurement_results` grabs the most recent index. (This step "just worked" by virtue of having a default index=-1). 4. Add an optional `index` property to `KeyCondition` to specify which index to use in classical controls (default `-1`). Step 5 will be a surprisingly straightforward follow-up to this one daxfohl/Cirq@repeated...daxfohl:repeated2 (still needs fleshed out for serializing the new field etc.). Step 6 is being done in parallel in quantumlib#4949 and subsequent PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow repeated measurement keys.
Implements steps 1, 2, 3, and 4 from #4274 (comment):
log_of_measurement_resultsgrabs the most recent index. (This step "just worked" by virtue of having a default index=-1).indexproperty toKeyConditionto specify which index to use in classical controls (default-1).Step 5 will be a surprisingly straightforward follow-up to this one daxfohl/Cirq@repeated...daxfohl:repeated2 (still needs fleshed out for serializing the new field etc.).
Step 6 is being done in parallel in #4949 and subsequent PRs.