Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate set_state_vector and set_density_matrix #4906

Merged
merged 3 commits into from
Jan 29, 2022

Conversation

daxfohl
Copy link
Contributor

@daxfohl daxfohl commented Jan 27, 2022

It was accepted at cirq sync that these are vestigial functions from a time when we didn't have initial_state or custom gates or classical controls that could be used for this. Now that we have all these, we can remove this function.

Fixes #4830

@daxfohl daxfohl requested review from cduck, vtomole and a team as code owners January 27, 2022 22:27
@daxfohl daxfohl requested a review from viathor January 27, 2022 22:27
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jan 27, 2022
@MichaelBroughton MichaelBroughton self-assigned this Jan 28, 2022
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would you mind adding _deprecated to the end of the test function names so that when we come back later we know we can just delete the test outright ?

@daxfohl
Copy link
Contributor Author

daxfohl commented Jan 28, 2022

LGTM, would you mind adding _deprecated to the end of the test function names so that when we come back later we know we can just delete the test outright ?

Done

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jan 29, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jan 29, 2022
@CirqBot CirqBot merged commit 2dc428b into quantumlib:master Jan 29, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jan 29, 2022
@daxfohl daxfohl deleted the dep_setstate branch January 29, 2022 22:32
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
It was accepted at cirq sync that these are vestigial functions from a time when we didn't have initial_state or custom gates or classical controls that could be used for this. Now that we have all these, we can remove this function.

Fixes quantumlib#4830
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
It was accepted at cirq sync that these are vestigial functions from a time when we didn't have initial_state or custom gates or classical controls that could be used for this. Now that we have all these, we can remove this function.

Fixes quantumlib#4830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we deprecate StateVectorStepResult.set_state()?
3 participants