Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up redundant use of _deprecate_attributes #4917

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

pavoljuhas
Copy link
Collaborator

deprecate_attributes replaces standard Python module with a wrapper
that modifies attribute access. Avoid unless truly needed.

@pavoljuhas pavoljuhas requested review from cduck, vtomole and a team as code owners January 29, 2022 03:01
@pavoljuhas pavoljuhas requested a review from viathor January 29, 2022 03:01
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jan 29, 2022
`deprecate_attributes` replaces standard Python module with a wrapper
that modifies attribute access.  Avoid unless truly needed.
@pavoljuhas pavoljuhas force-pushed the clean-noop-deprecation branch from 27f5989 to 6b42194 Compare January 29, 2022 03:02
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton self-assigned this Jan 29, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jan 29, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jan 29, 2022
@CirqBot CirqBot merged commit 275372e into quantumlib:master Jan 29, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jan 29, 2022
@pavoljuhas pavoljuhas deleted the clean-noop-deprecation branch January 31, 2022 01:10
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
`deprecate_attributes` replaces standard Python module with a wrapper
that modifies attribute access.  Avoid unless truly needed.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
`deprecate_attributes` replaces standard Python module with a wrapper
that modifies attribute access.  Avoid unless truly needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants