Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate device.decompose_operation in cirq-core. #4922

Merged

Conversation

MichaelBroughton
Copy link
Collaborator

Yet another deprecation for #4744 . Vendor deprecations of this fxn to follow.

@MichaelBroughton MichaelBroughton force-pushed the deprecate_device_decompose branch from d67300a to 0b4063b Compare February 1, 2022 00:09
Copy link
Collaborator

@tanujkhattar tanujkhattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many existing vendor devices in cirq use decompose_operation for compiling circuits. What's the plan to update them? We should do the deprecation in cirq-core after the corresponding devices have been updated / an explicit transformer for compilation has been provided?

For example:

@MichaelBroughton
Copy link
Collaborator Author

I'm aware of all the vendors that would need to have this deprecated. For Deprecations where the cirq-core removal would cause breaks or warnings to come up suddenly in the vendor packages we did the vendors first (#4757, #4812, #4820, #4821 all came before #4845 otherwise #4845 would have been huge). In this case since there aren't any breaks and the removals will be pretty straightforward for all the vendors I figured the order didn't matter that much. Would you prefer we still do them first ?

Copy link
Collaborator

@tanujkhattar tanujkhattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Feb 2, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Feb 2, 2022
@CirqBot CirqBot merged commit ec44575 into quantumlib:master Feb 2, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Feb 2, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Yet another deprecation for quantumlib#4744 . Vendor deprecations of this fxn to follow.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Yet another deprecation for quantumlib#4744 . Vendor deprecations of this fxn to follow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants