-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate device.decompose_operation in cirq-core. #4922
Deprecate device.decompose_operation in cirq-core. #4922
Conversation
d67300a
to
0b4063b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many existing vendor devices in cirq use decompose_operation
for compiling circuits. What's the plan to update them? We should do the deprecation in cirq-core after the corresponding devices have been updated / an explicit transformer for compilation has been provided?
For example:
Cirq/cirq-ionq/cirq_ionq/ionq_devices.py
Line 83 in 2faba7a
def decompose_operation(self, operation: cirq.Operation) -> cirq.OP_TREE: def decompose_operation(self, operation: cirq.ops.Operation) -> 'cirq.OP_TREE': Cirq/cirq-core/cirq/ion/ion_device.py
Line 90 in fd4e834
def decompose_operation(self, operation: ops.Operation) -> ops.OP_TREE: def decompose_operation(self, operation: cirq.Operation) -> cirq.OP_TREE: def decompose_operation(self, operation: ops.Operation) -> ops.OP_TREE:
I'm aware of all the vendors that would need to have this deprecated. For Deprecations where the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yet another deprecation for quantumlib#4744 . Vendor deprecations of this fxn to follow.
Yet another deprecation for quantumlib#4744 . Vendor deprecations of this fxn to follow.
Yet another deprecation for #4744 . Vendor deprecations of this fxn to follow.