Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename context.ignore_tags to context.tags_to_ignore in cirq.TransformerContext #4931

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

tanujkhattar
Copy link
Collaborator

tags_to_ignore is a more descriptive name and matches the existing tags_to_check terminology in transformer_primitives.

circuit: CIRCUIT_TYPE, *, tags_to_check: Optional[Sequence[Hashable]] = (MAPPED_CIRCUIT_OP_TAG,)

Since the transformer API is a new feature which hasn't been released yet, the rename can be done without deprecation.

@tanujkhattar tanujkhattar requested review from cduck, vtomole and a team as code owners February 2, 2022 07:51
@tanujkhattar tanujkhattar requested a review from dabacon February 2, 2022 07:51
@CirqBot CirqBot added the size: S 10< lines changed <50 label Feb 2, 2022
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Feb 2, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Feb 2, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Feb 2, 2022

Automerge cancelled: A required status check is not present.

Missing statuses: ['Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)']

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Feb 2, 2022
@tanujkhattar tanujkhattar merged commit 57e0920 into quantumlib:master Feb 2, 2022
@tanujkhattar tanujkhattar deleted the rename_tags branch February 2, 2022 18:11
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Co-authored-by: Cirq Bot <craiggidney+github+cirqbot@google.com>
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
Co-authored-by: Cirq Bot <craiggidney+github+cirqbot@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants