Move cirq/ops/moment.py to cirq/circuits/moment.py #4932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the already imported Moment.
Use `cirq.Moment` instead.
pavoljuhas
requested review from
cduck,
HGSilveri,
mrwojtek,
vtomole and
a team
as code owners
Use `cirq.circuits.Moment` instead.
mypy seems to interpret left-hand-side `ops.Moment` as attribute access and complains the attribute is not set.
|
@tanujkhattar - ready for review. |
tanujkhattar
approved these changes
Feb 3, 2022
cirq-core/cirq/protocols/json_test_data/PauliMeasurementGate.repr_inward
Outdated
Show resolved
Hide resolved
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* Move cirq/ops/moment.py to cirq/circuits/moment.py * Deprecate module cirq.ops.moment and cirq.ops.Moment * Ignore mypy error on setting submodule attribute mypy seems to interpret left-hand-side `ops.Moment` as attribute access and complains the attribute is not set. * Add test for `Moment._with_key_path_prefix_` * Decouple `with_key_path_prefix` test from `with_key_path` Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* Move cirq/ops/moment.py to cirq/circuits/moment.py * Deprecate module cirq.ops.moment and cirq.ops.Moment * Ignore mypy error on setting submodule attribute mypy seems to interpret left-hand-side `ops.Moment` as attribute access and complains the attribute is not set. * Add test for `Moment._with_key_path_prefix_` * Decouple `with_key_path_prefix` test from `with_key_path` Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate module cirq.ops.moment and attribute cirq.ops.Moment.
This finalizes #4838 by Tanuj Khattar.
Fixes #4665