Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tags_to_ignore flag to map_operations and merge_operations transformer primitives #4933

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Add tags_to_ignore flag to map_operations and merge_operations transformer primitives #4933

merged 3 commits into from
Feb 2, 2022

Conversation

tanujkhattar
Copy link
Collaborator

As requested in #4923

@tanujkhattar tanujkhattar requested review from cduck, vtomole and a team as code owners February 2, 2022 11:37
@CirqBot CirqBot added the size: M 50< lines changed <250 label Feb 2, 2022
@tanujkhattar
Copy link
Collaborator Author

Should also be useful to simplify #4933

cc @daxfohl

MichaelBroughton
MichaelBroughton approved these changes Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cirq-core/cirq/transformers/transformer_primitives_test.py Outdated Show resolved Hide resolved
@tanujkhattar tanujkhattar merged commit 92878fc into quantumlib:master Feb 2, 2022
@tanujkhattar tanujkhattar deleted the transformer_primitives_ignore_tags branch February 2, 2022 18:39
@tanujkhattar tanujkhattar mentioned this pull request Feb 2, 2022
Merged
@MichaelBroughton MichaelBroughton self-assigned this Feb 2, 2022
CirqBot pushed a commit that referenced this pull request Feb 4, 2022
@tanujkhattar
Add deep=True flag to recursively apply transformer primitives to s…
6806f6a 
…ubcircuits. (#4934)

- As requested in #4923
- Should also be useful to simplify #4933, cc @daxfohl
@tanujkhattar tanujkhattar mentioned this pull request Feb 8, 2022
Merged
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tanujkhattar @rht
Add tags_to_ignore flag to map_operations and merge_operations tran…
fe38693 
…sformer primitives (quantumlib#4933)

* Add tags_to_ignore flag to map_operations and merge_operations primitives
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tanujkhattar @rht
Add deep=True flag to recursively apply transformer primitives to s…
d89a8cd 
…ubcircuits. (quantumlib#4934)

- As requested in quantumlib#4923
- Should also be useful to simplify quantumlib#4933, cc @daxfohl
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@tanujkhattar
Add tags_to_ignore flag to map_operations and merge_operations tran…
e0f32a7 
…sformer primitives (quantumlib#4933)

* Add tags_to_ignore flag to map_operations and merge_operations primitives
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@tanujkhattar
Add deep=True flag to recursively apply transformer primitives to s…
86f5891 
…ubcircuits. (quantumlib#4934)

- As requested in quantumlib#4923
- Should also be useful to simplify quantumlib#4933, cc @daxfohl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@dstrain115 dstrain115 Awaiting requested review from dstrain115 dstrain115 was automatically assigned from quantumlib/cirq-maintainers

Assignees

@MichaelBroughton MichaelBroughton

Labels
size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanujkhattar @MichaelBroughton @CirqBot