Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to deprecated readthedocs documentation in Contribute page #4988

Merged
merged 4 commits into from
Mar 16, 2022

Conversation

augustehirth
Copy link
Collaborator

Removes the reference to the now-deprecated readthedocs documentation as noted in issue #4572.

The script mentioned (dev_tools/docs/build-rtd-docs.sh) is still present, maybe it should be removed as well?

@augustehirth augustehirth requested review from a team, vtomole and cduck as code owners February 13, 2022 02:50
@CirqBot CirqBot added the Size: XS <10 lines changed label Feb 13, 2022
@MichaelBroughton
Copy link
Collaborator

We might want to bring this up at an upcoming Cirq sync. I do recall there being some legacy support we wanted to keep here for others who are using RTD with us.

@MichaelBroughton MichaelBroughton self-assigned this Feb 18, 2022
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mentioned at Cirq sync and I think we're good to go.

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 16, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 16, 2022
@CirqBot CirqBot merged commit 083d2e5 into quantumlib:master Mar 16, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Mar 16, 2022
@augustehirth augustehirth deleted the issue_5472 branch March 23, 2022 18:45
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
…e page (quantumlib#4988)

Removes the reference to the now-deprecated readthedocs documentation as noted in issue quantumlib#4572. 

The script mentioned (`dev_tools/docs/build-rtd-docs.sh`) is still present, maybe it should be removed as well?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants