Reject multiplication of cirq.PauliSum inside in cirq.PauliString
#5010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtomole
changed the title
cirq.PauliSum inside of cirq.PauliString
vtomole
changed the title
cirq.PauliSum inside of cirq.PauliStringcirq.PauliSum inside in cirq.PauliString
MichaelBroughton
approved these changes
Feb 22, 2022
cirq-core/cirq/ops/pauli_string.py
Outdated
| @@ -1237,6 +1237,7 @@ def _imul_helper(self, other: 'cirq.PAULI_STRING_LIKE', sign: int): | |||
| Returns: | |||
| self on success, NotImplemented given an unknown type of value. | |||
| """ | |||
| from cirq.ops.linear_combinations import PauliSum | |||
There was a problem hiding this comment.
Nit: can we move this to a module level import at the top ? (even if it means wrapping in LazyLoader)
There was a problem hiding this comment.
Totally forgot about LazyLoader. Thank you. Done.
95-martin-orion
pushed a commit
to 95-martin-orion/Cirq
that referenced
this pull request
Mar 2, 2022
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5009