Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sets tolerance to 1.0e-8 by default in equivalence assertion #5017

Merged
merged 3 commits into from
Feb 23, 2022
Merged

Sets tolerance to 1.0e-8 by default in equivalence assertion #5017

merged 3 commits into from
Feb 23, 2022

Conversation

towynlin
Copy link
Contributor

As suggested in issue #4784

@towynlin towynlin requested review from a team, vtomole and cduck as code owners February 23, 2022 20:15
@towynlin towynlin requested a review from dabacon February 23, 2022 20:15
@CirqBot CirqBot added the Size: XS <10 lines changed label Feb 23, 2022
vtomole
vtomole requested changes Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this! Please modify a test in circuit_compare_test.py that keeps track of this change. For example, we can remove some of the explicit passes of atol from some of the tests in test_sensitive_to_measurement_but_not_measured_phase.

@towynlin
Copy link
Contributor Author

towynlin commented Feb 23, 2022 •
edited
Loading

Any objections to removing all/most instances of atol=1e-8? There are 18 that could potentially be deleted in circuit_compare_test.py across 7 test functions.

@vtomole
Copy link
Collaborator

vtomole commented Feb 23, 2022

That sounds good.

@CirqBot CirqBot added the size: S 10< lines changed <50 label Feb 23, 2022
@vtomole vtomole added automerge Tells CirqBot to sync and merge this PR. (If it's running.) and removed size: S 10< lines changed <50 labels Feb 23, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Feb 23, 2022
@vtomole vtomole added size: S 10< lines changed <50 and removed front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. Size: XS <10 lines changed labels Feb 23, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Feb 23, 2022
@CirqBot CirqBot merged commit 32f319d into quantumlib:master Feb 23, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Feb 23, 2022
@towynlin towynlin deleted the default-atol-issue-4784 branch February 23, 2022 21:48
@vtomole vtomole mentioned this pull request Feb 23, 2022
Closed
95-martin-orion pushed a commit to 95-martin-orion/Cirq that referenced this pull request Mar 2, 2022
@towynlin @95-martin-orion
Sets tolerance to 1.0e-8 by default in equivalence assertion (quantum…
5b92d27 
…lib#5017)

As suggested in issue quantumlib#4784
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@towynlin @rht
Sets tolerance to 1.0e-8 by default in equivalence assertion (quantum…
51e3a6c 
…lib#5017)

As suggested in issue quantumlib#4784
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@towynlin
Sets tolerance to 1.0e-8 by default in equivalence assertion (quantum…
c0fee63 
…lib#5017)

As suggested in issue quantumlib#4784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole approved these changes

@cduck cduck Awaiting requested review from cduck

@dabacon dabacon Awaiting requested review from dabacon dabacon was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@towynlin @vtomole @CirqBot