Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cg.workflow] Consistent get_sampler() #5030

Merged

Conversation

mpharrigan
Copy link
Collaborator

cg.SimulatedLocalProcessor(sampler=sampler).get_sampler() != sampler due to wrapping happening in the __init__ function.

Work around this by always using processor.get_sampler()

@CirqBot CirqBot added the size: S 10< lines changed <50 label Feb 25, 2022
@mpharrigan mpharrigan added area/workflow and removed size: S 10< lines changed <50 labels Feb 25, 2022
@CirqBot CirqBot added the size: S 10< lines changed <50 label Feb 25, 2022
@mpharrigan mpharrigan added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 7, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 7, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Mar 7, 2022

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Mar 7, 2022
@mpharrigan mpharrigan added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 7, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Mar 7, 2022

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 7, 2022
@vtomole
Copy link
Collaborator

vtomole commented Mar 7, 2022

We can't merge this until #5058 is fixed.

@mpharrigan mpharrigan added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 7, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Mar 7, 2022

Automerge cancelled: A status check is failing.

@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 7, 2022
@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 7, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 7, 2022
@CirqBot CirqBot merged commit 9cefed8 into quantumlib:master Mar 7, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Mar 7, 2022
@mpharrigan mpharrigan deleted the 2022-02-processor-record-sampler branch March 8, 2022 21:50
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
`cg.SimulatedLocalProcessor(sampler=sampler).get_sampler() != sampler` due to wrapping happening in the `__init__` function.

Work around this by always using `processor.get_sampler()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/workflow size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants