-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cg.workflow] Consistent get_sampler()
#5030
Merged
CirqBot
merged 3 commits into
quantumlib:master
from
mpharrigan:2022-02-processor-record-sampler
Mar 7, 2022
Merged
[cg.workflow] Consistent get_sampler()
#5030
CirqBot
merged 3 commits into
quantumlib:master
from
mpharrigan:2022-02-processor-record-sampler
Mar 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpharrigan
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
February 25, 2022 23:07
dstrain115
approved these changes
Feb 26, 2022
mpharrigan
added
the
automerge
Tells CirqBot to sync and merge this PR. (If it's running.)
label
Mar 7, 2022
CirqBot
added
the
front_of_queue_automerge
CirqBot uses this label to indicate (and remember) what's being merged next.
label
Mar 7, 2022
Automerge cancelled: A status check is failing. |
CirqBot
removed
automerge
Tells CirqBot to sync and merge this PR. (If it's running.)
front_of_queue_automerge
CirqBot uses this label to indicate (and remember) what's being merged next.
labels
Mar 7, 2022
mpharrigan
added
the
automerge
Tells CirqBot to sync and merge this PR. (If it's running.)
label
Mar 7, 2022
Automerge cancelled: A status check is failing. |
CirqBot
removed
the
automerge
Tells CirqBot to sync and merge this PR. (If it's running.)
label
Mar 7, 2022
We can't merge this until #5058 is fixed. |
mpharrigan
added
the
automerge
Tells CirqBot to sync and merge this PR. (If it's running.)
label
Mar 7, 2022
Automerge cancelled: A status check is failing. |
CirqBot
removed
the
automerge
Tells CirqBot to sync and merge this PR. (If it's running.)
label
Mar 7, 2022
vtomole
added
the
automerge
Tells CirqBot to sync and merge this PR. (If it's running.)
label
Mar 7, 2022
CirqBot
added
the
front_of_queue_automerge
CirqBot uses this label to indicate (and remember) what's being merged next.
label
Mar 7, 2022
CirqBot
removed
automerge
Tells CirqBot to sync and merge this PR. (If it's running.)
front_of_queue_automerge
CirqBot uses this label to indicate (and remember) what's being merged next.
labels
Mar 7, 2022
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
`cg.SimulatedLocalProcessor(sampler=sampler).get_sampler() != sampler` due to wrapping happening in the `__init__` function. Work around this by always using `processor.get_sampler()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cg.SimulatedLocalProcessor(sampler=sampler).get_sampler() != sampler
due to wrapping happening in the__init__
function.Work around this by always using
processor.get_sampler()