Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove public fields for pauli ops #5062

Merged
merged 3 commits into from
Mar 13, 2022
Merged

Remove public fields for pauli ops #5062

merged 3 commits into from
Mar 13, 2022

Conversation

daxfohl
Copy link
Contributor

@daxfohl daxfohl commented Mar 8, 2022

#4851 for all the pauli stuff.

I skipped BaseDensePauliString because including cirq._compat there makes a weird circular dependency.

@CirqBot CirqBot added the size: M 50< lines changed <250 label Mar 8, 2022
@daxfohl daxfohl mentioned this pull request Mar 8, 2022
Closed
13 tasks
@MichaelBroughton
Copy link
Collaborator

Did the LazyLoader not work in this case ?

@MichaelBroughton MichaelBroughton self-assigned this Mar 13, 2022
@daxfohl
Copy link
Contributor Author

daxfohl commented Mar 13, 2022

@MichaelBroughton Didn't try, but fixed it in #5064 by moving the dependency, which I think puts it in a better location anyway. If you have reservations about that, then let's continue that conversation on that issue.

MichaelBroughton
MichaelBroughton approved these changes Mar 13, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. LGTM after nit.

cirq-core/cirq/ops/pauli_measurement_gate.py Outdated Show resolved Hide resolved
@daxfohl daxfohl requested review from a team, vtomole and cduck as code owners March 13, 2022 21:03
@daxfohl daxfohl requested a review from tanujkhattar March 13, 2022 21:03
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 13, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 13, 2022
@CirqBot CirqBot merged commit d8652be into quantumlib:master Mar 13, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Mar 13, 2022
@daxfohl daxfohl deleted the privatevarspauli branch March 13, 2022 21:46
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@daxfohl @rht
Remove public fields for pauli ops (quantumlib#5062)
58e5d88 
quantumlib#4851 for all the pauli stuff.

I skipped BaseDensePauliString because including `cirq._compat` there makes a weird circular dependency.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@daxfohl
Remove public fields for pauli ops (quantumlib#5062)
e1c3e49 
quantumlib#4851 for all the pauli stuff.

I skipped BaseDensePauliString because including `cirq._compat` there makes a weird circular dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

@tanujkhattar tanujkhattar Awaiting requested review from tanujkhattar tanujkhattar was automatically assigned from quantumlib/cirq-maintainers

Assignees

@MichaelBroughton MichaelBroughton

Labels
size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daxfohl @MichaelBroughton @CirqBot