Replace _PhasedFSimConverter in cirq_google with new transformer primitives #5095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tanujkhattar
commented
Mar 17, 2022
tanujkhattar
commented
- Removes an internal optimizer and therefore we don't need to go through a deprecation cycle.
- Part of Migration of optimizers in vendor packages to new transformers infrastructure. #5028
tanujkhattar
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
MichaelBroughton
approved these changes
Mar 17, 2022
tanujkhattar
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A required status check is not present. Missing statuses: ['Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage'] |
CirqBot
removed
automerge
…ed_fsim_transformer
…ttar/Cirq into phased_fsim_transformer
tonybruguier
pushed a commit
to tonybruguier/Cirq
that referenced
this pull request
Apr 14, 2022
…itives (quantumlib#5095) * Replace _PhasedFSimConverter in cirq_google with new transformer primitives * Fix mypy types * Improve test coverage
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…itives (quantumlib#5095) * Replace _PhasedFSimConverter in cirq_google with new transformer primitives * Fix mypy types * Improve test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.