-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add json serialization to SycamoreTargetGateset. #5314
Add json serialization to SycamoreTargetGateset. #5314
Conversation
@@ -0,0 +1 @@ | |||
cirq_google.SycamoreTargetGateset(atol=1e-08, tabulation=None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repr json combo might need to go in the cirq_google json_test_data directory ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops my bad, thanks for the catch!
b97237d
to
9130aeb
Compare
9130aeb
to
512182b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a json roundtrip verification test which includes the two qubit gate tabulation to sycamore_gateset_test.py
?
A repr/json with tabulation set is omitted because the repr of cirq.two_qubit_gate_product_tabulation() is very long.
512182b
to
a9085bf
Compare
This makes it possible to fully serialize `GridDeviceMetadata`. A repr/json with tabulation set is omitted because the repr of cirq.two_qubit_gate_product_tabulation() is very long. @tanujkhattar
This makes it possible to fully serialize
GridDeviceMetadata
.A repr/json with tabulation set is omitted because the repr of cirq.two_qubit_gate_product_tabulation() is very long.
@tanujkhattar