DeviceSpecification serialization implementation #5375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verult
force-pushed
the
cg-device-refactor/device-serialization-impl
branch
2 times, most recently
from
aabeb10 to
2a5041d
Compare
verult
changed the title
verult
force-pushed
the
cg-device-refactor/device-serialization-impl
branch
from
2a5041d to
6bfd753
Compare
dstrain115
reviewed
May 20, 2022
dstrain115
approved these changes
Jun 1, 2022
verult
force-pushed
the
cg-device-refactor/device-serialization-impl
branch
2 times, most recently
from
8016228 to
6a2402e
Compare
* Serialization function uses the signature proposed in PR quantumlib#5323 * Can still populate a DeviceSpecification previously created from the old serialization method. This allows DeviceSpecification to be serialized in a backward-compatible way prior to the removal of old DeviceSpecification fields associated with `SerializableDevice`. * Refactored grid_device_test.py to reuse existing spec generation helper functions to proto serialization testing.
verult
force-pushed
the
cg-device-refactor/device-serialization-impl
branch
from
6a2402e to
2c8da3b
Compare
verult
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* Serialization function uses the signature proposed in PR quantumlib#5323 * Can still populate a DeviceSpecification previously created from the old serialization method. This allows DeviceSpecification to be serialized in a backward-compatible way prior to the removal of old DeviceSpecification fields associated with `SerializableDevice`. * Refactored grid_device_test.py to reuse existing spec generation helper functions to proto serialization testing. @dstrain115 @maffoo @tanujkhattar FYI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SerializableDevice.@dstrain115
@maffoo @tanujkhattar FYI