-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests against python 3.10 #5486
Conversation
Looks like we will need to update the grpc library version to support 3.10. |
Looks like the least intrusive upgrade here is |
I'm not aware of any problems with device and program protos. If we can go further and move to 3.15, that'd be even better - optional fields are only supported in >=3.15 and I'd like to make the |
@MichaelBroughton, I don't think bumping the grpcio-tools version will be a problem for cirq-google; we will have to regenerate the proto files, but that's easy, and the gapic code now uses the @verult, in proto3 all fields are optional by default, so I don't think we need to do anything special to treat |
The feature I'm looking for is to be able to distinguish between an unset field and a field which is set to the default value of the type. For See: https://stackoverflow.com/questions/42622015/how-to-define-an-optional-field-in-protobuf-3 |
Hm, we need to update mypy to get it to install on mac/windows with 3.10, but updating mypy update is not trivial. I'm inclined to disable 3.10 tests for windows and mac for now and do that as a follow-up. |
Why is updating mypy not trivial ? |
When I tried updating mypy to ~0.800 I saw O(20) new type errors; when I updated to the latest 0.961 it was more like O(50) errors. It might be that these are easy to fix, I didn't dive too deep. But in any even it felt like that might be better as a separate PR. |
mypy updated in #5767 so that we can now run 3.10 tests on windows and mac. @MichaelBroughton, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
me wants this
(making new cirq virtualenv and grpcio-tools fails to build, hoping this is the fix)
Automerge cancelled: A status check is failing. |
Test against all the versions.