Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Program.language.gate_set proto field #5591

Conversation

verult
Copy link
Collaborator

@verult verult commented Jun 23, 2022

Deprecating this field now that each device only has a single gateset and a single serializer.

Engine parsing logic will be updated to ignore other gate_set values other than the one corresponding to CircuitSerializer after 0.15, when global gatesets will be removed.

@dstrain115

@verult verult requested review from wcourtney, a team, vtomole and cduck as code owners June 23, 2022 21:57
@verult verult requested a review from 95-martin-orion June 23, 2022 21:57
@CirqBot CirqBot added the size: M 50< lines changed <250 label Jun 23, 2022
@verult verult requested a review from dstrain115 June 23, 2022 21:57
@verult verult added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 24, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 24, 2022
@CirqBot CirqBot merged commit 1827e11 into quantumlib:master Jun 24, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 24, 2022
@verult verult mentioned this pull request Jul 7, 2022
40 tasks
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Deprecating this field now that each device only has a single gateset and a single serializer.

Engine parsing logic will be updated to ignore other `gate_set` values other than the one corresponding to `CircuitSerializer` after 0.15, when global gatesets will be removed.

@dstrain115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants