Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a deprecation cycle for ArithmeticOp #5599

Merged
merged 3 commits into from
Jun 24, 2022
Merged

Conversation

daxfohl
Copy link
Contributor

@daxfohl daxfohl commented Jun 23, 2022

#4702 was started in November but did not get merged until May, which was after 14.1 went out. These deprecations need to be bumped to 0.16 instead of 0.15.

Once 0.15 goes out then I can reopen #5579 and delete these.

@daxfohl daxfohl requested review from a team, vtomole and cduck as code owners June 23, 2022 23:58
@daxfohl daxfohl requested a review from 95-martin-orion June 23, 2022 23:58
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jun 23, 2022
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dabacon dabacon added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 24, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 24, 2022
@CirqBot CirqBot merged commit 4837eef into quantumlib:master Jun 24, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 24, 2022
@daxfohl daxfohl deleted the dep2 branch June 24, 2022 23:42
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
quantumlib#4702 was started in November but did not get merged until May, which was after 14.1 went out. These deprecations need to be bumped to 0.16 instead of 0.15.

Once 0.15 goes out then I can reopen quantumlib#5579 and delete these.
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
quantumlib#4702 was started in November but did not get merged until May, which was after 14.1 went out. These deprecations need to be bumped to 0.16 instead of 0.15.

Once 0.15 goes out then I can reopen quantumlib#5579 and delete these.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants