Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DensePauliString and MutableDensePauliString docs and inconsistencies fixes #5624

Merged
merged 5 commits into from
Jul 7, 2022
Merged

DensePauliString and MutableDensePauliString docs and inconsistencies fixes #5624

merged 5 commits into from
Jul 7, 2022

Conversation

tanujkhattar
Copy link
Collaborator

Fixes #4835
Fixes #5352

@tanujkhattar tanujkhattar requested review from a team, vtomole and cduck as code owners June 27, 2022 02:18
@tanujkhattar tanujkhattar requested a review from maffoo June 27, 2022 02:18
@CirqBot CirqBot added the size: M 50< lines changed <250 label Jun 27, 2022
@tanujkhattar tanujkhattar requested a review from dabacon June 27, 2022 02:19
vtomole
vtomole reviewed Jun 27, 2022
View reviewed changes
cirq-core/cirq/ops/dense_pauli_string.py
# mypy false positive "Cannot determine type of 'I'"
identity.I, # type: ignore
PAULI_GATES: List[Union['cirq.Pauli', 'cirq.IdentityGate']] = [
identity.I,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we have a pauli_gates.I?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should have; I don't have a better answer, maybe @dabacon knows why we made this decision in the past.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @dabacon

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure there was ever a good reason. It is true that I is special, but likely we should have had it.

@vtomole vtomole mentioned this pull request Jun 27, 2022
Closed
dabacon
dabacon approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cirq-core/cirq/ops/dense_pauli_string_test.py Outdated Show resolved Hide resolved
@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 7, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 7, 2022
@CirqBot
Copy link
Collaborator

CirqBot commented Jul 7, 2022

Automerge cancelled: A required status check is not present.

Missing statuses: ['Build docs', 'Build protos', 'Coverage check', 'Notebook formatting', 'Pytest MacOS (3.7)', 'Pytest MacOS (3.8)', 'Pytest MacOS (3.9)', 'Pytest Ubuntu (3.7)', 'Pytest Ubuntu (3.8)', 'Pytest Ubuntu (3.9)', 'Pytest Windows (3.7)', 'Pytest Windows (3.8)', 'Pytest Windows (3.9)', 'Typescript lint check', 'Typescript tests', 'Typescript tests coverage']

@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 7, 2022
@tanujkhattar tanujkhattar merged commit f94d1f6 into master Jul 7, 2022
@vtomole vtomole deleted the document_dps branch July 7, 2022 02:03
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tanujkhattar @rht
DensePauliString and MutableDensePauliString docs and inconsisten…
2a977c9 
…cies fixes (quantumlib#5624)
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@tanujkhattar
DensePauliString and MutableDensePauliString docs and inconsisten…
3807d6f 
…cies fixes (quantumlib#5624)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole left review comments

@dabacon dabacon dabacon approved these changes

@cduck cduck Awaiting requested review from cduck

@maffoo maffoo Awaiting requested review from maffoo maffoo was automatically assigned from quantumlib/cirq-maintainers

Assignees

@dabacon dabacon

Labels
size: M 50< lines changed <250
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document the Plethora of PauliStrings. Operations on MutableDensePauliString return a DensePauliString
4 participants
@tanujkhattar @CirqBot @dabacon @vtomole