Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back the default on unitary to np.complex64, change default for final_state_vector #5636

Merged
merged 4 commits into from
Jun 29, 2022

Conversation

dabacon
Copy link
Collaborator

@dabacon dabacon commented Jun 28, 2022

Rolls back change in #5426 that set the default precision on Circuit#unitary to np.complex128.

Also sets the default on Circuit#final_state_vector to np.complex128. There was a deprecation warning that this was going to be downgraded to np.complex64,, but this will now remain np.complex128. This is breaking in that is someone explicitly passed dtype=None to this method it would now break.

Rolls back #5426 #5616 #5537 #5535

@dabacon dabacon added the BREAKING CHANGE For pull requests that are important to mention in release notes. label Jun 28, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the size: M 50< lines changed <250 label Jun 28, 2022
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 29, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 29, 2022
@CirqBot CirqBot merged commit f904a09 into quantumlib:master Jun 29, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 29, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
…final_state_vector (quantumlib#5636)

Rolls back change in quantumlib#5426 that set the default precision on `Circuit#unitary` to `np.complex128`.

Also sets the default on `Circuit#final_state_vector` to `np.complex128`.  There was a deprecation warning that this was going to be downgraded to `np.complex64`,, but this will now remain `np.complex128`.  This is breaking in that is someone explicitly passed `dtype=None` to this method it would now break.  

Rolls back quantumlib#5426 quantumlib#5616 quantumlib#5537 quantumlib#5535
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
…final_state_vector (quantumlib#5636)

Rolls back change in quantumlib#5426 that set the default precision on `Circuit#unitary` to `np.complex128`.

Also sets the default on `Circuit#final_state_vector` to `np.complex128`.  There was a deprecation warning that this was going to be downgraded to `np.complex64`,, but this will now remain `np.complex128`.  This is breaking in that is someone explicitly passed `dtype=None` to this method it would now break.  

Rolls back quantumlib#5426 quantumlib#5616 quantumlib#5537 quantumlib#5535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE For pull requests that are important to mention in release notes. size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants