Fix small issues in Shor tutorial #5639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use cirq.X instead of cirq.ops.X - Add a circuit_diagram_info for better printing - Add a few clarifications here and there. Also, this changes ArithmeticOperation to use a raw docstring so it will format better.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
viathor
requested changes
Jun 29, 2022
viathor
approved these changes
Jun 29, 2022
| " - the base\n", | ||
| " - the modulus\n", | ||
| "\n", | ||
| " Note that the target and exponent should be qubit\n", |
There was a problem hiding this comment.
Optional: Strictly speaking exponent can be either a qubit register or a fixed constant, though for specific application in Shor's algorithm we use the former.
There was a problem hiding this comment.
I think I will skip this technicality since this docstring is describing our particular implementation.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* Fix small issues in Shor tutorial - use cirq.X instead of cirq.ops.X - Add a circuit_diagram_info for better printing - Add a few clarifications here and there. Also, this changes ArithmeticOperation to use a raw docstring so it will format better.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
* Fix small issues in Shor tutorial - use cirq.X instead of cirq.ops.X - Add a circuit_diagram_info for better printing - Add a few clarifications here and there. Also, this changes ArithmeticOperation to use a raw docstring so it will format better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, this changes ArithmeticOperation to use a raw
docstring so it will format better.