-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate StrategyExecutor to new transformer infrastructure #5644
Migrate StrategyExecutor to new transformer infrastructure #5644
Conversation
syncing branch with main cirq repo
syncing with main cirq repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good start, I've left some comments. Please let me know if you have questions!
syncing with latest version of main Cirq repo
syncing with latest version of main Cirq repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left another round of comments.
I changed the argument and return type for the circuit that is being modified in the This is because the method I thought of changing the type of the circuit in the method signature of |
syncing with latest version of main Cirq repo
I also get those 2 failures when running tests locally, I suspect they need docker installation to pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good; a final round of comments!
merging with latest version of main Cirq repo
…ecutor syncing with latest version of main Cirq repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for all the iterations!
Migrated the StrategyExecutor class to strategy_executor() function that uses transformer_primitives. Depreciated StrategyExecutor.