Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more numpy / mypy typing issues #5669

Merged
merged 5 commits into from
Jul 7, 2022
Merged

Fix more numpy / mypy typing issues #5669

merged 5 commits into from
Jul 7, 2022

Conversation

pavoljuhas
Copy link
Collaborator

  • Fix type complaints for np.allclose arguments
  • Fix complaint about float-to-int assignment
  • Fix type-complaint about optional return value

@pavoljuhas pavoljuhas requested review from a team, vtomole and cduck as code owners July 6, 2022 23:19
@pavoljuhas pavoljuhas requested a review from viathor July 6, 2022 23:19
@CirqBot CirqBot added the size: S 10< lines changed <50 label Jul 6, 2022
@pavoljuhas pavoljuhas mentioned this pull request Jul 6, 2022
Merged
@pavoljuhas
Mea culpa - np.asarray needs a list
23873ae 
For it does not digest generator expression.
vtomole
vtomole approved these changes Jul 6, 2022
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dabacon dabacon added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 7, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 7, 2022
@CirqBot CirqBot merged commit 0a5886d into quantumlib:master Jul 7, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 7, 2022
@pavoljuhas pavoljuhas deleted the fix-mypy-numpy-errors-3 branch July 7, 2022 14:18
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@pavoljuhas @rht
Fix more numpy / mypy typing issues (quantumlib#5669)
2f083f6 
- Fix type complaints for np.allclose arguments
- Fix complaint about float-to-int assignment
- Fix type-complaint about optional return value
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@pavoljuhas
Fix more numpy / mypy typing issues (quantumlib#5669)
5ccd7fb 
- Fix type complaints for np.allclose arguments
- Fix complaint about float-to-int assignment
- Fix type-complaint about optional return value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole approved these changes

@cduck cduck Awaiting requested review from cduck

@viathor viathor Awaiting requested review from viathor viathor was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
size: S 10< lines changed <50
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavoljuhas @vtomole @dabacon @CirqBot