Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5702: prevent confusing error if dev_tools/modules.py is invoked without arguments #5706

Merged
merged 3 commits into from
Jul 11, 2022

Conversation

mhucka
Copy link
Contributor

@mhucka mhucka commented Jul 9, 2022

This PR changes main in dev_tools/modules.py in a very simple way: if the user invokes it without any arguments, it pretends that --help was given as the argument instead. This prevents the error described in issue #5702 and makes the whole thing a little bit more user friendly.

mhucka added 2 commits July 8, 2022 14:38
If no argument is given to modules.py, pretend --help was given.
@mhucka mhucka requested review from a team, vtomole and cduck as code owners July 9, 2022 01:12
@mhucka mhucka requested a review from tanujkhattar July 9, 2022 01:12
@CirqBot CirqBot added the Size: XS <10 lines changed label Jul 9, 2022
@mhucka mhucka changed the title Fix 5702 Fix 5702: prevent confusing error if dev_tools/modules.py is invoked without arguments Jul 9, 2022
@95-martin-orion 95-martin-orion added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 11, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 11, 2022
@CirqBot CirqBot merged commit 479398f into quantumlib:master Jul 11, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 11, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
…d without arguments (quantumlib#5706)

This PR changes `main` in `dev_tools/modules.py` in a very simple way: if the user invokes it without any arguments, it pretends that `--help` was given as the argument instead. This prevents the error described in issue quantumlib#5702 and makes the whole thing a little bit more user friendly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants