Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Deprecated Quil classes #5710

Merged
merged 12 commits into from
Jul 11, 2022
Merged

Remove Deprecated Quil classes #5710

merged 12 commits into from
Jul 11, 2022

Conversation

dstrain115
Copy link
Collaborator

  • Removes QuilFormatter, QuilOutput, and QuilXQubitGate

Changes all typing of QuilFormatter to string.Formatter

dstrain115 added 8 commits July 6, 2022 13:57
@dstrain115 dstrain115 requested review from a team, vtomole and cduck as code owners July 11, 2022 02:50
@dstrain115 dstrain115 requested a review from maffoo July 11, 2022 02:50
@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jul 11, 2022
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

MichaelBroughton
MichaelBroughton approved these changes Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelBroughton MichaelBroughton self-assigned this Jul 11, 2022
@MichaelBroughton MichaelBroughton added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 11, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 11, 2022
@CirqBot CirqBot merged commit e6e62c0 into quantumlib:master Jul 11, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 11, 2022
vtomole
vtomole reviewed Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the _quil_ methods from all the classes that implement them now.

rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@dstrain115 @rht
Remove Deprecated Quil classes (quantumlib#5710)
abdd392 
- Removes QuilFormatter, QuilOutput, and QuilXQubitGate
    
Changes all typing of QuilFormatter to string.Formatter
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@dstrain115
Remove Deprecated Quil classes (quantumlib#5710)
44c6118 
- Removes QuilFormatter, QuilOutput, and QuilXQubitGate
    
Changes all typing of QuilFormatter to string.Formatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole left review comments

@MichaelBroughton MichaelBroughton MichaelBroughton approved these changes

@cduck cduck Awaiting requested review from cduck

@maffoo maffoo Awaiting requested review from maffoo maffoo was automatically assigned from quantumlib/cirq-maintainers

Assignees

@MichaelBroughton MichaelBroughton

Labels
size: L 250< lines changed <1000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dstrain115 @MichaelBroughton @vtomole @CirqBot