Cache the hash of frozen circuits to avoid recomputing #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows what we previously did for GridQubit, but reworked to use `_compat.cached_method` and to compute the hash lazily.
viathor
approved these changes
Jul 12, 2022
| hash_cache = _compat._method_cache_name(self.__hash__) | ||
| if hash_cache in state: | ||
| state = state.copy() | ||
| del state[hash_cache] |
There was a problem hiding this comment.
Optional suggestion:
state = self.__dict__.copy()
hash_cache = _compat._method_cache_name(self.__hash__)
state.pop(hash_cache, None)
return stateRationale: This is consistent in always returning a copy of self.__dict__. Also, it avoids branching.
(If you choose to do this, apply to GridQubit, too.)
There was a problem hiding this comment.
AFAICT from the docs on __getstate__ it's not necessary to return a copy, since the pickle infrastructure does not modify the returned object. In fact, pickle will use self.__dict__ directly if __getstate__ is not defined.
maffoo
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
the
automerge
CirqBot
removed
the
front_of_queue_automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
This follows what we previously did for GridQubit, but reworked to use `_compat.cached_method` and to compute the hash lazily.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
This follows what we previously did for GridQubit, but reworked to use `_compat.cached_method` and to compute the hash lazily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows what we previously did for GridQubit, but reworked to use
_compat.cached_methodand to compute the hash lazily.