Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Observables and PauliStrings #5750

Merged
merged 4 commits into from
Jul 18, 2022
Merged

Conversation

augustehirth
Copy link
Collaborator

Add documentation on observables and PauliStrings.

@tanujkhattar PTAL.

@augustehirth augustehirth requested review from a team, vtomole and cduck as code owners July 13, 2022 10:44
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jul 13, 2022
docs/simulate/pauli_observables.ipynb Show resolved Hide resolved
docs/simulate/pauli_observables.ipynb Show resolved Hide resolved
docs/simulate/pauli_observables.ipynb Show resolved Hide resolved
@@ -0,0 +1,714 @@
{
Copy link
Collaborator

@dabacon dabacon Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #13.        typrint((3j * Xa * Zb) ** 3)

maybe also note that this works with math.exp?


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, interesting. Seems numpy falls back to pow but math does not.

docs/simulate/pauli_observables.ipynb Show resolved Hide resolved
docs/simulate/pauli_observables.ipynb Show resolved Hide resolved
Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

@dabacon
Copy link
Collaborator

dabacon commented Jul 13, 2022

Oh crap external does work on the notebooks. Not sure why it rendered bad when I looked at it!!!

@augustehirth augustehirth requested a review from dabacon July 14, 2022 23:12
@augustehirth augustehirth added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 18, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 18, 2022
@CirqBot CirqBot merged commit 1a59b58 into quantumlib:master Jul 18, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 18, 2022
@augustehirth augustehirth deleted the observables branch July 19, 2022 00:16
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Add documentation on observables and PauliStrings. 

@tanujkhattar PTAL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: L 250< lines changed <1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants