-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return processor_id and project_id in get_qcs_objects_for_notebooks #5759
Merged
CirqBot
merged 7 commits into
quantumlib:master
from
dstrain115:get_qcs_objects_for_notebook
Jul 14, 2022
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2e82893
Return processor_id and project_id in get_qcs_objects_for_notebooks
dstrain115 94c156a
Formatting
dstrain115 d93f54e
Add virtual option to ensure deterministic test behavior.
dstrain115 c716dd1
Streamline get_qcs_for_notebooks to use only virtual or prod engine.
dstrain115 e946b37
Fix typing
dstrain115 883583b
Typing fixed for realsies.
dstrain115 9357099
Merge branch 'master' into get_qcs_objects_for_notebook
CirqBot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,11 +17,13 @@ | |
|
||
|
||
def test_get_device_sampler(): | ||
result = get_qcs_objects_for_notebook() | ||
assert result.device is cg.Sycamore | ||
result = get_qcs_objects_for_notebook('not_a_valid_project_name') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it'd be good for the tests to continue to exercise the no-arguments call variant. Perhaps we can do both? (We already exercise passing both arguments on line 28 below.) |
||
assert isinstance(result.device, cg.GridDevice) | ||
assert not result.signed_in | ||
assert isinstance(result.sampler, cg.PhasedFSimEngineSimulator) | ||
assert result.is_simulator | ||
|
||
# Note: if running locally with application default credentials, | ||
# you actually will be signed_in | ||
result = get_qcs_objects_for_notebook("", "") | ||
assert not result.signed_in | ||
assert isinstance(result.device, cg.GridDevice) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests using the new fields, or would that break some QCS behavior?