Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cirq-google: Remove SerializableGateSet #5762

Merged
merged 9 commits into from
Jul 14, 2022
Merged

cirq-google: Remove SerializableGateSet #5762

merged 9 commits into from
Jul 14, 2022

Conversation

verult
Copy link
Collaborator

@verult verult commented Jul 13, 2022

Thank you, SerializableGateSet!

@dstrain115

@verult verult requested a review from dstrain115 July 13, 2022 23:42
@verult verult requested review from wcourtney, a team, vtomole and cduck as code owners July 13, 2022 23:42
@CirqBot CirqBot added the size: XL lines changed >1000 label Jul 13, 2022
verult added 4 commits July 14, 2022 00:08
@verult
Remove global gateset references
89c850d
@verult
Remove global gatesets
8327f1e
@verult
Remove common_serializers_test.py
21fbcb6 
Necessary for SerializableGateSet deprecation. The only remaining parts of `common_serializers.py` after removing all deprecations are `CIRCUIT_OP_[DE]SERIALIZER`, and they don't have tests in this file.
@verult
Remove SerializableGateSet
b5863ef
@verult verult force-pushed the cg-device-refactor/remove-serializable-gatesets branch from 7a086e6 to b5863ef Compare July 14, 2022 00:08
@verult
Copy link
Collaborator Author

verult commented Jul 14, 2022 •
edited
Loading

Test failure is from:

Cirq/cirq-google/cirq_google/serialization/arg_func_langs_test.py

Lines 156 to 172 in a2fd902

def test_infer_language():
with cirq.testing.assert_deprecated('SerializableGateSet', deadline='v0.16', count=None):
q = cirq.GridQubit(0, 0)
a = sympy.Symbol('a')
b = sympy.Symbol('b')
c_linear = cirq.Circuit(cirq.X(q) ** (b - a))
packed = cirq_google.XMON.serialize(c_linear)
assert packed.language.arg_function_language == 'linear'
c_empty = cirq.Circuit(cirq.X(q) ** b)
packed = cirq_google.XMON.serialize(c_empty)
assert packed.language.arg_function_language == ''
c_exp = cirq.Circuit(cirq.X(q) ** (b**a))
packed = cirq_google.XMON.serialize(c_exp)
assert packed.language.arg_function_language == 'exp'

Wanted to double check that defaulting to exp is intended for CircuitSerializer before removing the test.

@verult verult changed the title Remove SerializableGateSet cirq-google: Remove SerializableGateSet Jul 14, 2022
@verult verult mentioned this pull request Jul 14, 2022
Merged
@dstrain115
Copy link
Collaborator

Yeah, this is just the operators supported by sympy symbols. I think we should support 'exp' (ie. +, -, *, /, and **)

dstrain115
dstrain115 approved these changes Jul 14, 2022
View reviewed changes
Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@verult verult added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 14, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 14, 2022
@CirqBot CirqBot merged commit a7216fc into quantumlib:master Jul 14, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 14, 2022
@verult verult mentioned this pull request Jul 14, 2022
Closed
CirqBot pushed a commit that referenced this pull request Jul 15, 2022
@verult
cirq-google: Remove serializers (#5764)
7fe3423 
First few commits are from #5762

@dstrain115
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@verult @rht
cirq-google: Remove SerializableGateSet (quantumlib#5762)
7463123 
Thank you, `SerializableGateSet`!

@dstrain115
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@verult @rht
cirq-google: Remove serializers (quantumlib#5764)
60df315 
First few commits are from quantumlib#5762

@dstrain115
pavoljuhas added a commit to pavoljuhas/Cirq that referenced this pull request May 29, 2024
@pavoljuhas
Remove deprecated constants from cirq_google module
ebd99f3 
Long past the `v0.16` deprecation deadline.
The constant were invalid for almost 2 years after quantumlib#5762.
@pavoljuhas pavoljuhas mentioned this pull request May 29, 2024
Merged
pavoljuhas added a commit that referenced this pull request May 29, 2024
@pavoljuhas
Flush deprecations before minor release (#6622)
ab86979 
* Remove deprecated constants from cirq_google module.
  Long past the `v0.16` deprecation deadline, constants
  were invalid for almost 2 years after #5762.

* Remove deprecated method `cirq_google.Engine.sampler()`
  Long past the `v1.0` deprecation deadline.

* Purge deprecated arguments to `EngineProcessor.list_calibrations`
  `earliest_timestamp_seconds` and `latest_timestamp_seconds` are
  long past the `v1.0` deadline.

* Remove deprecated function `cirq_ionq.ionq_devices.decompose_to_device`.
  Long past the `v0.16` deadline.

Ref: https://github.com/quantumlib/Cirq/blob/main/release.md#before-you-release-flush-the-deprecation-backlog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstrain115 dstrain115 dstrain115 approved these changes

@wcourtney wcourtney Awaiting requested review from wcourtney

@vtomole vtomole Awaiting requested review from vtomole

@cduck cduck Awaiting requested review from cduck

Assignees
No one assigned
Labels
size: XL lines changed >1000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@verult @dstrain115 @CirqBot