Use Mapping instead of Dict in some grid device helper funcs #5790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maffoo
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
dstrain115
approved these changes
Jul 16, 2022
dstrain115
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
the
automerge
CirqBot
removed
the
front_of_queue_automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…lib#5790) The device metadata returns durations as `Mapping`, so it's helpful to accept `Mapping` in `create_device_specification_proto` instead of requiring `Dict`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device metadata returns durations as
Mapping, so it's helpful to acceptMappingincreate_device_specification_protoinstead of requiringDict.