Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document fix #5807

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Document fix #5807

merged 2 commits into from
Jul 22, 2022

Conversation

thisisjaymehta
Copy link
Contributor

Variable name on line 250 was qiubits
This is typo and correct variable name should be qubits as used in following lines of code.
This typo did not break code as qubits variable was previously declared on line 150 and hence this old variable was used here instead of the one which should be used.

This spelling mistake did not break the code because there is variable
with same name declared previously.
However inoreder to use current variable this spelling mistake needs to
be corrected.
Removed below line which my vscode editor added without asking me

"vscode": {
     "languageId": "python"
}
@thisisjaymehta thisisjaymehta requested review from a team, vtomole and cduck as code owners July 22, 2022 13:00
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-cla
Copy link

google-cla bot commented Jul 22, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@CirqBot CirqBot added the Size: XS <10 lines changed label Jul 22, 2022
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 22, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 22, 2022
@CirqBot CirqBot merged commit ac1ae09 into quantumlib:master Jul 22, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 22, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Variable name on line 250 was `qiubits`
This is typo and correct variable name should be `qubits` as used in following lines of code.
This typo did not break code as `qubits` variable was previously declared on line 150 and hence this old variable was used here instead of the one which should be used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants