Allow specifying settings field from Cirq-ionq #5817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports ionq users overriding default behavior in a variety of ways, and is set on the Service object for now.
Cynocracy
requested review from
dabacon,
ColemanCollins,
nakardo,
gmauricio,
a team,
vtomole and
cduck
as code owners
gmauricio
approved these changes
Aug 4, 2022
pavoljuhas
reviewed
Jun 15, 2023
pavoljuhas
approved these changes
Jun 15, 2023
|
ty! |
suggestion by Pavol Juhas
vtomole
force-pushed
the
cirq-settings
branch
from
538a3f1 to
ed38fe5
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5817 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 1104 1104
Lines 95887 95897 +10
=======================================
+ Hits 93866 93876 +10
Misses 2021 2021
☔ View full report in Codecov by Sentry. |
shef4
added a commit
to shef4/Cirq
that referenced
this pull request
Sep 29, 2023
Allow specifying settings field from Cirq-ionq (quantumlib#5817)
shef4
added a commit
to shef4/Cirq
that referenced
this pull request
Oct 2, 2023
Allow specifying settings field from Cirq-ionq (quantumlib#5817)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports ionq users overriding default behavior in a variety of ways, and is set on the Service object for now.