Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert iterator to list to list before looping through moments in def insert #5820

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Convert iterator to list to list before looping through moments in def insert #5820

merged 1 commit into from
Aug 8, 2022

Conversation

vtomole
Copy link
Collaborator

@vtomole vtomole commented Aug 8, 2022

Fixes: #5819

@vtomole vtomole requested review from a team and cduck as code owners August 8, 2022 21:10
@vtomole vtomole requested a review from pavoljuhas August 8, 2022 21:10
pavoljuhas
pavoljuhas approved these changes Aug 8, 2022
View reviewed changes
Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice fix.

Interestingly, the same happens for a = [0]; a.extend(iter(a))
(be ready to suspend and kill Python before it eats all memory).

@vtomole vtomole merged commit 253534f into quantumlib:master Aug 8, 2022
@vtomole vtomole deleted the append_hand branch August 8, 2022 21:48
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@vtomole @rht
Convert iterator to list to list before looping through moments r ops…
c8d30d6 
… in insert (quantumlib#5820)
harry-phasecraft pushed a commit to PhaseCraft/Cirq that referenced this pull request Oct 31, 2024
@vtomole
Convert iterator to list to list before looping through moments r ops…
fb34de4 
… in insert (quantumlib#5820)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavoljuhas pavoljuhas pavoljuhas approved these changes

@cduck cduck Awaiting requested review from cduck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strange behavior after upgrading to cirq 0.1.0
2 participants
@vtomole @pavoljuhas