Adds unitary testing for routed circuits #5846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanujkhattar
requested changes
Aug 31, 2022
There was a problem hiding this comment.
As discussed offline, let's change the API of the testing method (and router implementation) to take an actual and expected circuit with the same set of qubits, along with a qubit_map that maps the initial qubits of actual to it's final qubit mapping. As a fallback, if the qubit_map is not specified, the method can potentially try to construct a qubit map by looking at the swaps operations in the actual circuit.
|
@tanujkhattar I've made the changes we discussed without the fallback strategy as a v1. I can follow up with that with another PR once we have a fully functioning basic routing implementation pushed to Cirq. |
ammareltigani
requested review from
tanujkhattar
and removed request for
MichaelBroughton
tanujkhattar
requested changes
Sep 2, 2022
tanujkhattar
requested changes
Sep 2, 2022
…igani/Cirq into routing-unitary_testing syncing with master
tanujkhattar
approved these changes
Sep 2, 2022
tanujkhattar
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Adds utilitiy functions that tests whether two circuits define the same unitary up to permutation of qubits.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
Adds utilitiy functions that tests whether two circuits define the same unitary up to permutation of qubits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds utilitiy functions that tests whether two circuits define the same unitary up to permutation of qubits.