Fix typing complaints showing at numpy 1.23 #5856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uantumlib#5853)" This reverts commit fb1b9bc.
Convert numpy scalars and arrays to native Python types.
cirq.Operation has no `__pow__`, the GateOperation subclass has.
Use np.reshape instead.
pavoljuhas
requested review from
mrwojtek,
a team,
vtomole and
cduck
as code owners
tanujkhattar
approved these changes
Sep 6, 2022
tanujkhattar
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Closed
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
- Revert "Restrict numpy version to unblock inflight PRs from failing (quantumlib#5853)" - Clarify wording of ValueError message - Fix typing complaints on non-native numeric types - Fix complaint on float.__rpow__(cirq.Operation) use - cirq.Operation has no `__pow__`, but the GateOperation subclass has - Fix complaint about vstack on generic array - clean up unused "type: ignore" comments Resolves quantumlib#5852. Reverts quantumlib#5853.
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
- Revert "Restrict numpy version to unblock inflight PRs from failing (quantumlib#5853)" - Clarify wording of ValueError message - Fix typing complaints on non-native numeric types - Fix complaint on float.__rpow__(cirq.Operation) use - cirq.Operation has no `__pow__`, but the GateOperation subclass has - Fix complaint about vstack on generic array - clean up unused "type: ignore" comments Resolves quantumlib#5852. Reverts quantumlib#5853.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cirq.Operation has no
__pow__, but the GateOperation subclass hasResolves #5852.
Reverts #5853.