Add support for repeated keys in result protos #5907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maffoo
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
wcourtney
requested changes
Oct 21, 2022
| // | ||
| // The bytes in this field are constructed as follows: | ||
| // | ||
| // 1. The results of the measurements produce a list of bits ordered by | ||
| // the round of repetition. | ||
| // the round of repetition and instance within a round. |
There was a problem hiding this comment.
I didn't notice any tests that confirm this behavior. Can you add them or point me to them? Thanks!
There was a problem hiding this comment.
I see tests that you can serialize and deserialize with the expected result, but not that the serialization follows the contract listed in this proto.
wcourtney
approved these changes
Oct 21, 2022
| // | ||
| // The bytes in this field are constructed as follows: | ||
| // | ||
| // 1. The results of the measurements produce a list of bits ordered by | ||
| // the round of repetition. | ||
| // the round of repetition and instance within a round. |
There was a problem hiding this comment.
I see tests that you can serialize and deserialize with the expected result, but not that the serialization follows the contract listed in this proto.
| assert isinstance(proto, v2.result_pb2.Result) | ||
| assert len(proto.sweep_results) == 2 | ||
| deserialized = v2.results_from_proto(proto, measurements) | ||
| assert len(deserialized) == 2 |
There was a problem hiding this comment.
Prefer to test behavior independently rather than rolling many separate assertions into one monolithic test.
go/unit-testing-practices#behavior-testing-examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step toward supporting repeated keys in circuits run through quantum engine. I need to expand the tests to cover cases where instances > 1, but the main logic is ready for review.