Remove checks so that hold_time is sweepable
#5919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliottrosenberg
requested review from
wcourtney,
a team,
vtomole,
cduck and
verult
as code owners
maffoo
approved these changes
Oct 13, 2022
| @@ -67,28 +63,12 @@ def __init__( | |||
| rise_time: Width of the rising (or falling) action of the trapezoidal pulse. | |||
| padding_time: Symmetric padding around the coupler pulse. | |||
|
|
|||
| Raises: | |||
There was a problem hiding this comment.
nit: also remove preceding blank line
verult
approved these changes
Oct 14, 2022
verult
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Allows the hold time in `CouplerPulse` to be swept. See quantumlib#5918
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the hold time in
CouplerPulseto be swept.See #5918