Add support for arbitrary angles to IonQ native MS Gate #5920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmauricio
requested review from
dabacon,
ColemanCollins,
nakardo,
a team,
vtomole and
cduck
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Cynocracy
approved these changes
Oct 17, 2022
vtomole
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
LGTM.
@gmauricio You'll need to sign the CLA for me to me to be able to merge.
gmauricio
force-pushed
the
ms-arbitrary-angle
branch
from
23c7a0f to
1f5530d
Compare
vtomole
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ionq's native MSGate now supports an additional parameter for an arbitrary theta angle.
This angle defaults to 0.25, equivalent to a PI/2 rotation, which matches previous definition. The value is specified in fractions of 2PI, same as in phases.